search

jsigbiz / spec

JavaScript signature notation
131 stars 6 forks source link

refactor generics section to use custom types #19

Closed Raynos closed 9 years ago

Raynos commented 9 years ago

we now have the type label : syntax for custom types so this should be used whenever you use a type that is not a builtin.

junosuarez commented 9 years ago

@raynos could you update the PR to include the correct Callback signature and a note indicating that it's an approximate type signature? At a minimum, I think it's important to note that the return value of Promise<T>.then is Promise<Any>, rather than void.

Raynos commented 9 years ago

@jden Updated this branch / PR based on your feedback.

junosuarez commented 9 years ago

:+1: ty