Closed malbernaz closed 6 years ago
Hi @jsillitoe, could you release a new version of this package to npm with the latest commits on master? Because this issue is fixed, but this is not available as a npm published version.
Still running into problems, as do other users https://github.com/jsillitoe/react-currency-input/issues/60 due to the npm version not having been updated. Can we do anything about it right now locally? Like force the module to use React 16?
Updated.
you still need to remove them from dependencies
.
@jsillitoe this should be re-opened. Just added this package to my project and it added dozens of additional packages in my lock file. It looks like devDependencies
are being added. Not sure if it's supposed to do that or not.
@bsell93 can you post the diff of your package-lock.json
file?
Of course! @navarroaxel
The npm published version react-currency-input@1.3.6
has this on the package.json
:
"dependencies": {
"babel-cli": "6.26.0",
"babel-preset-es2015": "6.24.1",
"babel-preset-react": "6.24.1",
"babel-register": "6.26.0",
"browserify": "13.3.0",
"jsdom": "9.12.0",
"prop-types": "15.6.0",
"rimraf": "2.6.2",
"sinon": "1.17.7",
"sinon-chai": "2.14.0",
}
These packages are included as devDependencies
too. The npm
don't install the devDependencies
on npm install <package>
but the dependencies
(production) are required when you need to use a given package.
I don't know why this happens, because the master
of this repo only has these packages as devDependencies
.
Are we able to change that?
Or rather it sounds like the package needs "redeployed" to npm?
@jsillitoe can publish a fixed version "1.3.7".
@jsillitoe any motion here? Isn't that just running the npm publish
cli? Because it looks like Github is correct 🤷♂
How to reproduce:
There are two problems here:
react-dom
andprop-types
) should be installed as peer dependencies rather than normal ones. I'm having a problem in which a project I'm working on have two conflicting versions ofreact
.which is explained in this thread.
I'll be happy to submit a PR in the case you are too busy too make these changes.
Thank you very much for this awesome project, it's been a life saver!