Fix ArtDMX length handling

jsimonetti / go-artnet

This package attempts to implement the Art-Net 4 specification from (c) Artistic Licence Holding Ltd.

MIT License

33 stars 20 forks source link

Fix ArtDMX length handling #17

Closed jsimonetti closed 5 years ago

jsimonetti commented 5 years ago

We did not check the length when marshaling and unmarshaling ArtDMX packets. Ref #16

@apinnecke This changes the ArtDMX packets generated by this library (ever so slightly). Could you check this does not break on your end? Works for me, but I have a very forgiving setup :) Edit: ignore above comment. Only the unmarshalling of ArtDMX packets is changed. Marshalling (creating) ArtDMX is identical to the previous version.

jsimonetti commented 5 years ago

Since this does not change packet generation, but only reception (ie. running this library as a node instead of a controller) I think it is safe to merge. Mainly because in its current state the library is not very suitable for running a Node (hopefully this changes with #16)