search

jsimonetti / go-artnet

This package attempts to implement the Art-Net 4 specification from (c) Artistic Licence Holding Ltd.
MIT License
33 stars 20 forks source link

Partial implementation of the port info for ArtPollReply #37

Closed 72nd closed 9 months ago

72nd commented 9 months ago

The control software I use only sends Art-Net data to a node if it contains the port info. This pull request causes the ArtPollReply to specify the correct number and type of ports. The input/output status is still not declared correctly.

A single ArtPollReply can declare a maximum of four node ports (otherwise several ArtPollReplys would have to be sent one after the other, which this patch does not implement). A validation method therefore checks at node.Start() whether the configuration (number of ports and matching types) is permissible at all.

jsimonetti commented 9 months ago

Hi! Thank you for your contribution. Could you please sign-off on your commits?

72nd commented 9 months ago

Commits should now be signed off.

jsimonetti commented 9 months ago

Thank you for the contribution!