Adds an option to change the listen-on address and exposes the UDP connection

jsimonetti / go-artnet

This package attempts to implement the Art-Net 4 specification from (c) Artistic Licence Holding Ltd.

MIT License

33 stars 20 forks source link

Adds an option to change the listen-on address and exposes the UDP connection #38

Open bmurray opened 9 months ago

bmurray commented 9 months ago

This lets the caller set the IP and Port. Useful on multi-homed servers.

This also exposes the udp connection on a Node, in case one wants to send a raw DMX packet, or otherwise.

jsimonetti commented 9 months ago

Hi! Thank you for your contribution. Not all your commits contain a sign-off. Could you please sign-off on these? I dont mind if you squash everything.

bmurray commented 9 months ago

Sorry about that. Should be good now!

aklinkert commented 9 months ago

@bmurray Unfortunately the commits are still not shown as signed. Did you add your signing key brian@bmurray.ca to GitHub?

bmurray commented 9 months ago

I'm pretty new to signing so I didn't realize there was a GPG signing option too. Rather confusing. I was able to sign with a new GPG key. It says verified now, so I think its good.

aklinkert commented 9 months ago

@bmurray Can you please resolve the conflicts?