search

jsitaraman / tioga

Tioga is a library for overset grid assembly on parallel distributed systems
GNU Lesser General Public License v3.0
67 stars 36 forks source link

Replace macros with TIOGA_ prefix to avoid conflicts #2

Closed sayerhs closed 6 years ago

sayerhs commented 6 years ago

Replace all macros (Min/Max, MIN/MAX, and free) with TIOGA_ prefixed versions to avoid conflicts with builtins as well as other codes.

sayerhs commented 6 years ago

@jsitaraman Leaving out codetypes.h from MeshBlock.h header will fail with compilation of external codes because it needs definitions of the structs declared in codetypes.h. I have updated the code so that we do leave in codetypes.h but the macros have been prefixed with TIOGA_ so that they don't conflict with builtins or other codes.

Currently, namespace is only applied to TIOGA class definitions, but since tioga.h header pulls in MeshBlock.h etc. it still leaks TIOGA stuff into the common namespace.