search

jsitaraman / tioga

Tioga is a library for overset grid assembly on parallel distributed systems
GNU Lesser General Public License v3.0
64 stars 36 forks source link

remove now redundant device-related functionalities in MeshBlock and dMeshBlock #57

Closed ashesh2512 closed 3 years ago

ashesh2512 commented 3 years ago

This pull request revises upon #53 to not only remove the obsolete set data functions, but also removes m_info_device from MeshBlock. It is sufficient for only dMeshBlock to own m_info_device since all MB gpu kernels are launched in dMeshBlock.

sayerhs commented 3 years ago

@ashesh2512 I feel that the objective should be to remove dMeshBlock and consolidate the logic into MeshBlock

jsitaraman commented 3 years ago

Does this pull request break the fake gpu pathway ? Also, merging of dMeshBlock and MeshBlock should be a later step after the implementation is complete. It's not ready for that at this point. There is enough difference in the underlying search and preprocessing routines to keep them separate.

ashesh2512 commented 3 years ago

@jsitaraman I have tested the fake gpu pathway and the gpu build as well. Both don't present any issues with the set of tests I usually run.