jsjoeio / speak-argentinian-spanish

speak argentinian spanish website
https://speakargentinianspanish.com/
1 stars 0 forks source link

404 page #16

Closed coding-in-public closed 1 year ago

coding-in-public commented 1 year ago

You may want to change the wording of the page, but hopefully the functionality looks good! As always, feel free to take or leave anything.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
speak-argentinian-spanish ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 10:58pm
coding-in-public commented 1 year ago

Oh, and I would be interested in you looking at the commits. Is this more in the right direction?

jsjoeio commented 1 year ago

Yes, exactly! Way easier to see the chunks and how this all came together :D

nit: I prefer when the first word is not capitalized but that's more a personal style 🤣

Overall, nice work man! Thanks for adding this!

jsjoeio commented 1 year ago

Oh and I don't know if you knew this but you can tie PRs to issues and have them autoclose when the PR merges by using special keywords like "fixes"

Fixes https://github.com/jsjoeio/speak-argentinian-spanish/issues/14

coding-in-public commented 1 year ago

I didn't actually know that about the Fixes, etc. Thanks!