search

jsjoeio / speak-argentinian-spanish

speak argentinian spanish website
https://speakargentinianspanish.com/
1 stars 0 forks source link

Fancy footer #44

Closed coding-in-public closed 1 year ago

coding-in-public commented 1 year ago

Quick job, but hopefully this mostly works :)

Fixes #12

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
speak-argentinian-spanish ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 5:09pm
coding-in-public commented 1 year ago

@jsjoeio, also I should mention that it looks like we’re using Ranade Medium, but it looks like you’d like a lighter version. Want me to move the body font to Ranade Regular? (it’s slightly lighter)

coding-in-public commented 1 year ago

@jsjoeio Hey, yeah! I'll get that typeface updated. For the homepage, I actually removed the new footer because the layout needs to be adjusted more broadly to include it. I'm happy to come up with a refactored homepage, too, but also happy to put that into a new branch if that's better? For now I'll change out the typeface.

jsjoeio commented 1 year ago

For the homepage, I actually removed the new footer because the layout needs to be adjusted more broadly to include it. I'm happy to come up with a refactored homepage, too, but also happy to put that into a new branch if that's better?

Ah gotcha!! Sure that works, I'll merge this one then we can do the refactor + footer on homepage in separate PR! 🚀