Select reference model - Githubissues

jsjol / diGP

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Select reference model #73

Closed jsjol closed 7 years ago

jsjol commented 7 years ago

Preferably from among those in Dipy:

DTI: works
DKI: works (but fails miserably at extrapolating)
SHORE: "prediction not implemented"
MAP-MRI: works (Dipy >= 0.12)
Generalized q-space sampling: "prediction not implemented"
Constant Solid Angle (CSA): "prediction not implemented"

jsjol commented 7 years ago

For the MAP-MRI implementation to enforce the positivity constraint it has to use CVXOPT. There are two issues with this

CVXOPT is licensed under GPL
CVXOPT in Windows only supports Python 2.7 and 3.4. Linux is better.

jsjol commented 7 years ago

From the GPL faq:

If a library is released under the GPL (not the LGPL), does that mean that any program which uses it has to be under the GPL? Yes, because the program as it is actually run includes the library.

However, this is subject to some debate.

jsjol commented 7 years ago

I think 1 above could be handled by having the file in question licensed under GPL.

jsjol commented 7 years ago

could be resolved by downgrading Python or switching to Python 3.4 when running the file needing this. I don't fancy this option.

The reason CVXOPT does not support 3.5+ is explained here: https://github.com/cvxopt/cvxopt/issues/94

jsjol commented 7 years ago

I'll try to use MAP-MRI as the reference method. See #74 for details.