jsk-ros-pkg / geneus

3 stars 16 forks source link

[geneus_main.py] Resolve package dependencies with attention to the order #17

Closed wkentaro closed 9 years ago

wkentaro commented 9 years ago

This is to solve these issue::

k-okada commented 9 years ago

!!! Thanks!!!

wkentaro commented 9 years ago

This modification may still not solve the problem, when the package has deep implicit dependencies. So DON'T MERGE THIS PR now.

That is difficult to solve dependent order with removing duplicate in function package_depends_impl.

So why not to get all dependencies first, and then check the order? This process solves::

I wrote the code:: https://github.com/wkentaro/geneus/commit/3aedcd2d0e80090ec0c0afb4a2c36396b0d571e6

k-okada commented 9 years ago

Ok, so can we merge this?

wkentaro commented 9 years ago

If the ros::load-ros-package fails depending on the order, this new code also can cause same error in some case. I'd like to close this PR and have you merge #18 instead.

wkentaro commented 9 years ago

I close this. See #18