search

jsk-ros-pkg / geneus

3 stars 16 forks source link

fix ros::load-ros-package order by dependencies #7

Closed furushchev closed 9 years ago

furushchev commented 9 years ago

refered from https://github.com/jsk-ros-pkg/jsk_recognition/issues/701 I think it resolve the problem.

k-okada commented 9 years ago

does reverse solve this issue? on is this only solution for the problem?

◉ Kei Okada

On Sat, Feb 14, 2015 at 5:09 PM, Furushchev notifications@github.com wrote:

refered from jsk-ros-pkg/jsk_recognition#701 https://github.com/jsk-ros-pkg/jsk_recognition/issues/701

I think it resolve the problem.

You can view, comment on, or merge this pull request online at:

https://github.com/jsk-ros-pkg/geneus/pull/7 Commit Summary

  • fix ros::load-ros-package order by dependencies

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/jsk-ros-pkg/geneus/pull/7.

furushchev commented 9 years ago

I think, the arg ARG_MSG_DEPS at the macro _generate_eus in cmake/geneus-extras.cmake.em is dep pkgs ordered by resolving dependencies and ARG_MSG is the package to be generated message. Geneus is called like: ${GENEUS_BIN} ${ARG_MSG} (a.k.a args[1]) ${ARG_MSG_DEPS}(a.k.a arg[2:]) so I think it's only way to do. (args[1:].reverse() would collapse the order of ${ARG_MSG_DEPS})

k-okada commented 9 years ago

ok, please write that explanation in the code

◉ Kei Okada

On Sun, Feb 15, 2015 at 7:46 PM, Furushchev notifications@github.com wrote:

I think, the arg ARG_MSG_DEPS at the macro _generate_eus in cmake/geneus-extras.cmake.em is dep pkgs ordered by resolving dependencies and ARG_MSG is the package to be generated message. Geneus is called like: ${GENEUS_BIN} ${ARG_MSG} (a.k.a args[1]) ${ARG_MSG_DEPS}(a.k.a arg[2:]) so I think it's only way to do. `

— Reply to this email directly or view it on GitHub https://github.com/jsk-ros-pkg/geneus/pull/7#issuecomment-74412556.

k-okada commented 9 years ago

ping

k-okada commented 9 years ago

can't wait ,please merge https://github.com/furushchev/geneus/pulls

furushchev commented 9 years ago

I'm very sorry for the late response. Now I merged.

k-okada commented 9 years ago

thanks!