search

jsk-ros-pkg / jsk_3rdparty

42 stars 60 forks source link

fails tweeting with image on PR2 #14

Closed furushchev closed 9 years ago

furushchev commented 9 years ago

pr2 often fails to tweet with image: https://twitter.com/pr2jsk/status/634221745029820416

Amazing! Furushchev has used PR2 for 55 minutes, I'm not tired!
(image not published)

rostwitter uses /tmp to store image published, but PR2 does not share /tmp on 2 PCs (c1 and c2), because rostwitter could not find image tweeted on another pc.

may be good to store image on $HOME/.rostwitter?

garaemon commented 9 years ago

Who does save the image?

2015年8月20日木曜日、Furushchevnotifications@github.comさんは書きました:

pr2 often fails to tweet with image: https://twitter.com/pr2jsk/status/634221745029820416

Amazing! Furushchev has used PR2 for 55 minutes, I'm not tired! (image not published)

rostwitter uses /tmp to store image published, but PR2 does not share /tmp on 2 PCs (c1 and c2), because rostwitter could not find image tweeted on another pc.

may be good to store image on $HOME/.rostwitter?

— Reply to this email directly or view it on GitHub https://github.com/jsk-ros-pkg/jsk_3rdparty/issues/14.

✉︎ from iPhone

furushchev commented 9 years ago

Or scp image to host which executes tweet.py when needs? (maybe need to change jsk_robot_start/lifelog/tweet_client.l)

k-okada commented 9 years ago

so you need to run iamge_saver at the machine runnning rostwitter

furushchev commented 9 years ago

@garaemon every nodes which publishes /tweet topic.

furushchev commented 9 years ago

@k-okada ok. I'll create PR.

k-okada commented 9 years ago

https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_pepper_robot/jsk_pepper_startup/launch/jsk_pepper_startup.launch#L34

k-okada commented 9 years ago

I don't think this is rostwitter problem, but pr2 launch file is not correct. see papper case, running rostwitter and image_save at same machine and https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_pepper_robot/jsk_pepper_startup/nodes/tweet.l just calls to save images

(the papper code is same as https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_robot_common/jsk_robot_startup/lifelog/tweet.l#L18, so we need to merge them)

garaemon commented 9 years ago

How about saving image inside of rostwitter instead of using image_saver?

furushchev commented 9 years ago

is there no problem if we remove the feature to read image topic from parameter /active_user/image_topic? and use remap instead.

(defvar *camera-topic-name* "/kinect_head_c2/rgb/image_rect_color")
(when (ros::has-param "/active_user/image_topic")
  (setq *camera-topic-name* (ros::get-param "/active_user/image_topic"))
  )
k-okada commented 9 years ago

On Thu, Aug 20, 2015 at 4:20 PM, Furushchev notifications@github.com wrote:

the feature to read image topic from parameter /active_user/image_topic?

what it this? who is reading this topic?

◉ Kei Okada

furushchev commented 9 years ago

actual code is here: https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_robot_common/jsk_robot_startup/lifelog/tweet_client.l#L5-L8

k-okada commented 9 years ago

oh, you can change tweet_client.l to use image_saver, not extract_images

◉ Kei Okada

On Thu, Aug 20, 2015 at 11:59 PM, Furushchev notifications@github.com wrote:

https://github.com/jsk-ros-pkg/jsk_robot/blob/master/jsk_robot_common/jsk_robot_startup/lifelog/tweet_client.l#L5-L8

— Reply to this email directly or view it on GitHub https://github.com/jsk-ros-pkg/jsk_3rdparty/issues/14#issuecomment-133041044 .