jsk-ros-pkg / jsk_3rdparty

42 stars 60 forks source link

[dialogflow_task_executive] use one sharp for commentout #376

Closed knorth55 closed 2 years ago

knorth55 commented 2 years ago

multiple sharps in comments causes build error in indigo PR1040.

Errors     << dialogflow_task_executive:make /home/applications/ros/indigo/logs/dialogflow_task_executive/build.make.013.log      
Traceback (most recent call last):
  File "/home/applications/ros/indigo/src/locusrobotics/catkin_virtualenv/catkin_virtualenv/scripts/combine_requirements", line 85, in <module>
    sys.exit(combine_requirements(**vars(args)))
  File "/home/applications/ros/indigo/src/locusrobotics/catkin_virtualenv/catkin_virtualenv/scripts/combine_requirements", line 56, in combine_requirements
    requirement_string, str(vcs_err), str(semver_err)))
RuntimeError: Could not match requirement ### for VCS (No match for ^(?P<scheme>git|git\+https|git\+ssh|git\+git|hg\+http|hg\+https|hg\+static-http|hg\+ssh|svn|svn\+svn|svn\+http|svn\+https|svn\+ssh|bzr\+http|bzr\+https|bzr\+ssh|bzr\+sftp|bzr\+ftp|bzr\+lp)://((?P<login>[^/@]+)@)?(?P<path>[^#@]+)(@(?P<revision>[^#]+))?(#egg=(?P<name>[^&]+))?$) or SemVer (Invalid requirement, parse error at "'###'")
make[2]: *** [generated_requirements.txt] Error 1
make[2]: *** Deleting file `generated_requirements.txt'
make[1]: *** [CMakeFiles/dialogflow_task_executive_generate_virtualenv.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
cd /home/applications/ros/indigo/build/dialogflow_task_executive; catkin build --get-env dialogflow_task_executive | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
..................................................................................................................................
Failed     << dialogflow_task_executive:make           [ Exited with code 2 ]                                                     
708yamaguchi commented 2 years ago

I see. catkin_virtualenv/combine_requirements (which is replaced in the latest version) cannot parse #### expression.

I think this PR is ok to be merged after CI pass.

knorth55 commented 2 years ago

all build passed. I'm also trying to fix indigo build error in github actions. https://github.com/k-okada/jsk_3rdparty/pull/8

knorth55 commented 2 years ago

this PR is merged in #365