search

jsk-ros-pkg / jsk_3rdparty

42 stars 60 forks source link

[aques_talk] build as x86 when dpkg cpu check fails #387

Closed knorth55 closed 1 year ago

knorth55 commented 2 years ago

now aques_talk is not build in indigo because dpkg version is low 1.17.5. we can use -qDEB_TARGET_GNU_CPU in dpkg 1.17.14 and above, so it does not return any value in 1.17.5. this PR continues to run build as x86_64 when dpkg version is low.

k-okada commented 2 years ago

nice catch, please add test code to prevent regression, you can use this commit https://github.com/jsk-ros-pkg/jsk_3rdparty/commit/c725427a0ac2c563afead15af0560761fb459996

◉ Kei Okada

2022年10月11日(火) 22:53 Shingo Kitagawa @.***>:

now aques_talk is not build in indigo because dpkg version is low 1.17.5. we can use -qDEB_TARGET_GNU_CPU in dpkg 1.17.14 and above, so it does not return any value in 1.17.5. this PR continues to run build as x86_64 when dpkg version is low.

You can view, comment on, or merge this pull request online at:

https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/387 Commit Summary

File Changes

(1 file https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/387/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYNXHJL7U2E4D4OU35SATWCVWIBANCNFSM6AAAAAARCJ7D4I . You are receiving this because you are subscribed to this thread.Message ID: @.***>

knorth55 commented 1 year ago

I don't get the point. How can I test this issue? indigo just build as x86_64 architecture.

k-okada commented 1 year ago

please rebase on top of #418, which check if dpkg-cpu check fails

knorth55 commented 1 year ago

Thanks, I rebased this PR on #418