jsk-ros-pkg / jsk_3rdparty

42 stars 60 forks source link

[ros_ speech_recognition] update default arg for speech_recognition.launch #412

Closed knorth55 closed 1 year ago

knorth55 commented 1 year ago

this PR changes the default value for speech_recognition.launch. with this change, speech_recognition.launch automatically starts and recognized results are published in /speech_to_text topic.

without this PR, we need to run rosservice call /~~~ to start speech_recognition node and the output topic is published in /Tablet/voice.

knorth55 commented 1 year ago

I update the readme.

k-okada commented 1 year ago

I understand using default topic name as /Tablet/voice was very bad idea, but to change this, we need to fix existing programs, for example -> https://github.com/knorth55/jsk_3rdparty/pull/36

knorth55 commented 1 year ago

@k-okada Thank you, I updated.

k-okada commented 1 year ago

humm, why we can find restart failed job button.... https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs

Screenshot from 2023-01-25 10-29-30

knorth55 commented 1 year ago

@k-okada

humm, why we can find restart failed job button.... docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs

The button will appear when all the jobs are finished. When some jobs are running, the button does not appear.