jsk-ros-pkg / jsk_3rdparty

42 stars 60 forks source link

[gdrive_ros] fix sys.version error #429

Closed knorth55 closed 1 year ago

knorth55 commented 1 year ago

in python3, sys.version cannot be compared with int 3. this PR fixes the issue.

In [4]: sys.version_info < 3                       
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-4a285b5ed8a1> in <module>
----> 1 sys.version_info < 3

TypeError: '<' not supported between instances of 'sys.version_info' and 'int'
In [5]: sys.version_info.major < 3                 
Out[5]: False
k-okada commented 1 year ago

even in Python2, it not working...

$ python2
Python 2.7.17 (default, Nov 28 2022, 18:51:39) 
[GCC 7.5.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.version_info < 3
False
>>> sys.version_info.major < 3
True
>>> sys.version_info
sys.version_info(major=2, minor=7, micro=17, releaselevel='final', serial=0)
>>> sys.version_info.major
2
knorth55 commented 1 year ago

even in Python2, it not working...

Yes, I tried in Python2 and I found out that this line is not working properly.

https://github.com/jsk-ros-pkg/jsk_3rdparty/commit/0e9602ff1e13d71b48bf75443982677b69d3c010

Hmm, it was my fault :innocent: