Closed soonhyo closed 1 year ago
Nice catch. Importing modules are missing in __init__.py
when migrating.
But I'm not sure this is a correct way to fix.
I think it's the correct way.
test failes
Error: ker_ros:make] [respeaker_ros.rosunit-ros_rospy_node/test_rosnode][ERROR]----------------------
[respeaker_ros:make] cannot import name usb_pixel_ring_v1
[respeaker_ros:make] File "/usr/lib/python2.7/unittest/case.py", line 329, in run
[respeaker_ros:make] testMethod()
[respeaker_ros:make] File "/github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/respeaker_ros/test/test_rospy_node.py", line 34, in test_rosnode
[respeaker_ros:make] exec(open(filename, encoding='utf-8').read()) in globals(), locals()
[respeaker_ros:make] File "<string>", line 5, in <module>
[respeaker_ros:make] File "/github/home/ros/ws_jsk_3rdparty/src/jsk_3rdparty/respeaker_ros/src/respeaker_ros/__init__.py", line 25, in <module>
[respeaker_ros:make] from pixel_ring import usb_pixel_ring_v2
[respeaker_ros:make] File "/github/home/ros/ws_jsk_3rdparty/devel/.private/respeaker_ros/share/respeaker_ros/venv/lib/python2.7/site-packages/pixel_ring/__init__.py", line 3, in <module>
[respeaker_ros:make] from . import usb_pixel_ring_v1
[respeaker_ros:make] --------------------------------------------------------------------------------
[respeaker_ros:make]
[respeaker_ros:make]
[respeaker_ros:make] SUMMARY
[respeaker_ros:make] * RESULT: FAIL
[respeaker_ros:make] * TESTS: 1
[respeaker_ros:make] * ERRORS: 1
[respeaker_ros:make] * FAILURES: 0
@soonhyo I am very very sorry to commit wrong code and thanks for your fix. I have cahnged test code and confirmed that they passed CI #478
Currently,
roslaunch respeaker_ros sample_respeaker.launch
does not work on melodic, Python 2.7.17:This seems due to https://github.com/jsk-ros-pkg/jsk_3rdparty/commit/4ea7e8bfa5332999628a531c8d3fa0be2ac02601 and this PR fixes the error by moving all
import
into__init__.py
. But I'm not sure this is a correct way to fix.