search

jsk-ros-pkg / jsk_common

common programs for jsk-ros-pkg
42 stars 81 forks source link

[jsk_topic_tools] add non static_tf mode to static_tf_republisher #1709

Closed sktometometo closed 2 years ago

sktometometo commented 2 years ago

Update static_tf_republisher

sktometometo commented 2 years ago

CI fails. fixing now.

sktometometo commented 2 years ago

I would like to use jsk_data library in building phase of jsk_topic_tools in order to download a sample rosbag file. But jsk_data has jsk_topic_tools in its package.xml as exec_depend. So if I add jsk_data to package.xml of jsk_topic_tools, it will have a circular dependency. (This causes current CI failure).

I think there are some options to solve this situation.

  1. Split jsk_data package into two (jsk_topic_tools dependent package and independent package.)
  2. Stage the sample rosbag data directly into this git repository.
  3. Update the downloading script so that it will download the sample data without jsk_data. (almost reimplementation).

Each option has pros. and cons. Option 1 will make jsk_data dependency clear, but we have to change all pacakges depends on jsk_data. Option 2 is the most simple solution, but it will greatly increase the size of this git repository (and debian package). Option 3 seems to have the small side effect. but it will cause duplicated downloading implementation.

I think Option 3 is a better solution than others. Is there any advice or suggention?

@k-okada @iory

iory commented 2 years ago

How about using catkin_download_test_data ?http://docs.ros.org/en/jade/api/catkin/html/howto/format2/downloading_test_data.html

iory commented 2 years ago

For example, add following lines in CMakeLists.txt.

catkin_download(download_sample_tf_bag https://drive.google.com/uc?id=15i7dPbMxrxR0j6KsH5mSgIWrNNTrYoV4
  DESTINATION ${CMAKE_CURRENT_SOURCE_DIR}/samples/data
  FILENAME sample_tf.bag
  MD5 13cd56d8d85cdf80139bbe5f7a9e2ef0
  )
add_custom_target(download ALL DEPENDS download_extra_data)
sktometometo commented 2 years ago

Rebased on jsk-ros-pkg/master and use catkin_download() instead of jsk_data

sktometometo commented 2 years ago

CIs failed. I will fix them.

sktometometo commented 2 years ago

CI failures seem to be unrelated to this PR. Tests for static_tf_republisher have succeeded.