Closed 708yamaguchi closed 2 years ago
fetch1075's rqt robot monitor
This looks good! Could you add a test and sample like https://github.com/jsk-ros-pkg/jsk_common/pull/1711/files
Thank you for your review.
I add sample
roslaunch jsk_tools sample_sanity_diagnostics.launch
and test
rostest jsk_tools test_sanity_diagnostics.test
Result:
Sorry for force-push. I summerize commits 23 -> 6.
This looks good. https://github.com/jsk-ros-pkg/jsk_common/runs/6422833587?check_suite_focus=true#step:7:9433 Please fix the test error.
Thank you!
I updated the code and fixed the test error.
This node checks topic and node status and publishes
/diagnostics
topic.I refine https://github.com/jsk-ros-pkg/jsk_robot/pull/1460 by using
sanity_lib.py
. https://github.com/jsk-ros-pkg/jsk_common/blob/a3d26ac5243c108cec25d4108d93b3f0fd57c503/jsk_tools/src/jsk_tools/sanity_lib.pyIn the future, I think robot speaks
/diagnostics
topic with this script. https://github.com/jsk-ros-pkg/jsk_common/pull/1607