search

jsk-ros-pkg / jsk_common

common programs for jsk-ros-pkg
42 stars 81 forks source link

[jsk_topic_tools/DiagnosticsNodelet] Enable constructor without name argument #1761

Closed iory closed 2 years ago

iory commented 2 years ago

What is this?

Related to https://github.com/jsk-ros-pkg/jsk_recognition/pull/2712 The jsk nodes use ConnectionBasedNodelet and DiagnosticsNodelet.

https://github.com/jsk-ros-pkg/jsk_recognition/pull/2712#discussion_r918957879 If we want to write the following, we need to create a constructor with no arguments in DiagnosticsNodelet.


#if  defined(JSK_TOPIC_TOOLS_VERSION) and JKS_NODELET_VERSION_MINIMUM(2,2,13))
    #define jsk_topic_tools::NODLET jsk_topic_tools::ConnectionBasedNodelet
#else
    #define jsk_topic_tools::NODLET jsk_topic_tools::DiagnosticNodelet
#endif```