jsk-ros-pkg / jsk_common

common programs for jsk-ros-pkg
42 stars 81 forks source link

[jsk_data/download_data.py] Add timeout argument to download() for wget #1771

Closed nakane11 closed 1 year ago

nakane11 commented 1 year ago

The build of jsk_pcl_ros does not terminate because torus.pcd is inaccessible. https://github.com/jsk-ros-pkg/jsk_recognition/blob/62facef973dd8a54e179c90b514ea54c8b0fdd83/jsk_pcl_ros/scripts/install_sample_data.py#L130-L135 wget timeout is 900s and tries is 20 by default, so we have to wait for the end for 5 hours.

This PR sets default timeout=30 and fixes tries=1. When verbose is false, we can tell the cause of failure as follows.

$ roscd jsk_pcl_ros
$ python scripts/install_sample_data.py
[/home/nakane/.ros/data/jsk_pcl_ros/torus.pcd] Failed downloading. exit_status: 4
[/home/nakane/.ros/data/jsk_pcl_ros/torus.pcd] checking md5sum)
[/home/nakane/.ros/data/jsk_pcl_ros/torus.pcd] Finished checking md5sum
[/home/nakane/.ros/data/jsk_pcl_ros/torus.pcd] Downloading from https://blog.innovotion.co.jp/wp-content/uploads/2018/08/torus.pcd
[/home/nakane/.ros/data/jsk_pcl_ros/torus.pcd] Failed downloading. exit_status: 4
[/home/nakane/.ros/data/jsk_pcl_ros/torus.pcd] md5sum mismatched! expected: 17ae9636f42403a20bf1b936c03bb35c vs actual: d41d8cd98f00b204e9800998ecf8427e

cc @iory