search

jsk-ros-pkg / jsk_control

jsk control ros packages
http://github.com/jsk-ros-pkg/jsk_control
14 stars 51 forks source link

Migrate srv files from jsk_pcl_ros to jsk_recognition_msgs #637

Closed wkentaro closed 7 years ago

wkentaro commented 8 years ago

Background

Some packages in jsk_visualization depends on jsk_pcl_ros because it uses the srv files. But jsk_pcl_ros is a very large package and the dependency should be avoided ideally. The solution is placing msg/srv files into jsk_recognition_msgs.

Plans

  1. Merge this after jsk_recognition_msgs is released: http://repositories.ros.org/status_page/ros_indigo_default.html?q=jsk_recognition_msgs
  2. Release this pacakge.
  3. Remove jsk_pcl_ros/srv.
  4. Release jsk_pcl_ros.

Related PRs

k-okada commented 7 years ago

@wkentaro

  1. please update this branch
  2. please add more explanation on https://github.com/jsk-ros-pkg/jsk_control/pull/637#issue-184627261, a) why we need this, b) what is the plan
  3. please update https://github.com/jsk-ros-pkg/jsk_recognition/pull/1827#issuecomment-256150923 once this PR is merged.
wkentaro commented 7 years ago

Done all.

k-okada commented 7 years ago

thank you, please update jsk-ros-pkg/jsk_recognition#1827 (comment) once this PR is merged. BTW, why this PR passes? I think we do not release newer version of jsk_recognition to hydro..

wkentaro commented 7 years ago

BTW, why this PR passes? I think we do not release newer version of jsk_recognition to hydro..

Maybe because they are only in lisp code and there's no tests..