search

jsk-ros-pkg / jsk_control

jsk control ros packages
http://github.com/jsk-ros-pkg/jsk_control
14 stars 51 forks source link

[jsk_teleop_joy] add pygame to run depend #657

Closed kochigami closed 7 years ago

kochigami commented 7 years ago

This pull-request is about midi_config_player.py. rosrun jsk_teleop_joy midi_config_player.py ../configs/launchpad_mini.yaml

  1. This includes pygame, therefore I added it to run depend in package.xml of jsk_teleop_joy.

python-pygame is installed when we run

cd ~/catkin_ws
rosdep install -y -r --from-paths src --ignore-src
  1. To avoid the warning below, I added queue_size 
    /home/kochigami/catkin_ws/src/jsk_control/jsk_teleop_joy/scripts/midi_config_player.py:54: SyntaxWarning: The publisher should be created with an explicit keyword argument 'queue_size'. Please see http://wiki.ros.org/rospy/Overview/Publishers%20and%20Subscribers for more information.
joy_pub = rospy.Publisher("/joy", Joy)

If there is any problem, please let me know.

k-okada commented 7 years ago

LGTM