[eus_qp/optmotiongen/euslisp/inverse-kinematics-wrapper.l] Fix load path

[kyawawa]

Fix load path to load inverse-kinematics-wrapper.l from directories other than the sample or demo directory.

[mmurooka]

Thank you.

@k-okada , could you merge this please?

[k-okada]

Can we create test code for this?

[mmurooka]

OK, I'll try.

[k-okada]

I think just to run sample code is enough to catch this type of error

2019年2月14日(木) 21:04 Masaki Murooka notifications@github.com:

OK, I'll try.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/jsk-ros-pkg/jsk_control/pull/703#issuecomment-463603014, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3CCjLXu4FaefEIhoUyvLeDi2pjhaks5vNVDIgaJpZM4a7O85 .

--

◉ Kei Okada

[mmurooka]

I think just to run sample code is enough to catch this type of error

That's not true in this case (so, I did not notice this mistake.) Travis test is done as we intended. But this kind of error is not found.

From the test directory, error is not reproduced as follows:

$ touch hoge.l
$ touch fuga.l
$ echo "(load \"../fuga.l\")" > ./hoge.l ;; actually, "../fuga.l" should be "./fuga.l"                                                                                                                                                                   
$ mkdir test
$ cd test/
$ roseus "(load \"../hoge.l\")" ;; this does not cause error                                                                                                                                                                                             
$ cd ..
$ roseus "(load \"./hoge.l\")" ;; this becomes error        

[k-okada]

hunn I think test code is run from ~/.ros/ directory, please look at cwd option of roslaunch

http://wiki.ros.org/roslaunch/XML/node

2019年2月14日(木) 21:16 Masaki Murooka notifications@github.com:

I think just to run sample code is enough to catch this type of error

That's not true in this case (so, I did not notice this mistake.) Travis test is done as we intended. But this kind of error is not found.

From the test directory, error is not reproduced as follows:

$ touch hoge.l $ touch fuga.l $ echo "(load \"../fuga.l\")" > ./hoge.l ;; actually, "../fuga.l" should be "./fuga.l" $ mkdir test $ cd test/ $ roseus "(load \"../hoge.l\")" ;; this does not cause error $ cd .. $ roseus "(load \"./hoge.l\")" ;; this becomes error

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/jsk-ros-pkg/jsk_control/pull/703#issuecomment-463606095, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3F-azvP1E15OZzQA3ji1YnGVVZ1xks5vNVOPgaJpZM4a7O85 .

--

◉ Kei Okada

[mmurooka]

Thank you for your comment, I'll look at cwd option.

But I think we cannot find error from test even if test is executed from ~/.ros/ directory. The following is the reason:

# generate directory structure and source files
$  touch hoge.l
$  touch fuga.l
$  echo "(load \"../fuga.l\")" > ./hoge.l # actually, "../fuga.l" should be "./fuga.l"
$  mkdir test
$  cd test/
$  touch piyo.l
$  echo "(load \"../hoge.l\")" > ./piyo.l # this is correct
# when doing tests
$  cd ..
$  mkdir .ros
$  cd .ros # go to test executing directory
$  roseus ../test/piyo.l # execute test, this does not cause error, so we cannot notice mistake.

So I think we need to add another test for find this mistake.