search

jsk-ros-pkg / jsk_demos

JSK demo programs
https://github.com/jsk-ros-pkg/jsk_demos
25 stars 89 forks source link

[jsk_maps] Fix fetch_dock_position #1389

Closed sktometometo closed 1 year ago

sktometometo commented 1 year ago

Fix Fetch's docking station position wrongly changed by https://github.com/jsk-ros-pkg/jsk_demos/pull/1381.

k-okada commented 1 year ago 
.github/workflows/config.yml / ros (noetic, jskrobotics/ros-ubuntu:20.04-pcl, python3-rospkg python3-rospkg-modules) (pull_request) Failing after 12m

The noetic test is expected to fail (that's why it does not 'required'), so if someone confirm this PR, then we're ready to merge.

Regarding the noteic test, see https://github.com/jsk-ros-pkg/jsk_demos/pull/1390

sktometometo commented 1 year ago

@mqcmd196 @Kanazawanaoaki @tkmtnt7000 Could you review this PR?

mqcmd196 commented 1 year ago

Before the PR image

After the PR image

And the other spots are reasonable image

mqcmd196 commented 1 year ago

When checking on my local PC, https://github.com/jsk-ros-pkg/jsk_demos/pull/1361 was helpful.

knorth55 commented 1 year ago

FYI: @tkmtnt7000 you are right. i made the spot not for dock place, but for dock's approach position. for that reason, i named it as dock-front. but maybe i misused this spot in some program, probably.