search

jsk-ros-pkg / jsk_model_tools

JSK model utilities
https://github.com/jsk-ros-pkg/jsk_model_tools
BSD 3-Clause "New" or "Revised" License
5 stars 27 forks source link

get name from the eus model if the argument name is not passed #169

Closed mmurooka closed 8 years ago

mmurooka commented 8 years ago

eusモデルをurdfに変換するスクリプトを微修正しました．

mmurooka commented 8 years ago

Cloud you review and merge if no problem?

k-okada commented 8 years ago

please rebase origin/master

k-okada commented 8 years ago

I still have doubt on supporting eus->urdf converter because I can not take responsibility for this, so 1) please add test code for this 2) please add your name to maintainer

mmurooka commented 8 years ago

I still have doubt on supporting eus->urdf converter because I can not take responsibility for this, so 1) please add test code for this 2) please add your name to maintainer

I agree with supporting eus->urdf converter so I will make another PR and do 1) and 2). But before that, I'd like to double check that these codes are originally added by NOT only my opinion but discussing with some major JSK members. cf. https://github.com/jsk-ros-pkg/jsk_demos/pull/988#issuecomment-118694277

mmurooka commented 8 years ago

Travis passed. Commit of test code is merged and test passed. Cloud you merge?