jsk-ros-pkg / jsk_model_tools

JSK model utilities
https://github.com/jsk-ros-pkg/jsk_model_tools
BSD 3-Clause "New" or "Revised" License
5 stars 27 forks source link

[euscollada] add add_normal argument #214

Closed YoheiKakiuchi closed 5 years ago

YoheiKakiuchi commented 6 years ago

default behavior is removing normals, because normals increase file size and loading time.

k-okada commented 6 years ago

please check both collada2eus.cpp and collada2eus_urdfmodel, or please working on https://github.com/jsk-ros-pkg/jsk_model_tools/issues/36

-- ◉ Kei Okada

2018-04-06 18:11 GMT+09:00 Yohei Kakiuchi notifications@github.com:

default behavior is removing normals, because normals increase file size and loading time.

You can view, comment on, or merge this pull request online at:

https://github.com/jsk-ros-pkg/jsk_model_tools/pull/214 Commit Summary

  • [euscollada] add add_normal argument

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jsk-ros-pkg/jsk_model_tools/pull/214, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3D2dawNDhxnOD9H4Gw1NWiO3mJjnks5tlzFegaJpZM4TJvS6 .

k-okada commented 5 years ago

https://github.com/jsk-ros-pkg/jsk_model_tools/pull/216 がマージされたので,これも変更がありますでしょうか?

YoheiKakiuchi commented 5 years ago

216 にコミットが含まれていました。