search

jsk-ros-pkg / jsk_model_tools

JSK model utilities
https://github.com/jsk-ros-pkg/jsk_model_tools
BSD 3-Clause "New" or "Revised" License
5 stars 27 forks source link

collada2eus_urdfmodel: append provide on bottom; force flush #219

Closed furushchev closed 5 years ago

furushchev commented 5 years ago

The old collada2eus (now collada2eus.orig) appended a provide function and force flushing which is now missing on the new converter.

k-okada commented 5 years ago

@furushchev please ask @YoheiKakiuchi for review directory

YoheiKakiuchi commented 5 years ago

A candidate of version string is

fprintf(fp, "(%s %s %s) at %s\n", uname_buf.nodename, uname_buf.release, name_buf.machine, ctime(&tm));

Printed sample is

(leus-ThinkPad-P50 4.15.0-30-generic x86_64) at Wed Aug  8 19:50:59 2018
furushchev commented 5 years ago

@YoheiKakiuchi Thanks for the review. I updated to use strftime instead of ctime from the proposed version string, because ctime puts \n at the end of the string. Now output looks like:

(provide :pr2 "(mochi 4.15.0-32-generic x86_64) at 2018-09-04 14:42:48 JST")

k-okada commented 5 years ago

released into indigo and kinetic -> https://github.com/ros/rosdistro/pull/19042 https://github.com/ros/rosdistro/pull/19043

◉ Kei Okada

2018年9月4日(火) 15:21 Yohei Kakiuchi notifications@github.com:

Merged #219 https://github.com/jsk-ros-pkg/jsk_model_tools/pull/219 into master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jsk-ros-pkg/jsk_model_tools/pull/219#event-1824424138, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeG3IARMrA623xFb3qXWrQiA-5_1cUGks5uXhvfgaJpZM4WWhZo .