Fix for being deprecated tag: cfmDamping -> implicitSpringDamper

jsk-ros-pkg / jsk_model_tools

JSK model utilities

https://github.com/jsk-ros-pkg/jsk_model_tools

BSD 3-Clause "New" or "Revised" License

5 stars 27 forks source link

Fix for being deprecated tag: cfmDamping -> implicitSpringDamper #222

Closed k-okada closed 5 years ago

k-okada commented 5 years ago

rebased version of #183 Closes #183

mttamtam commented 5 years ago

It is a bit off topic from here, but I'm curious about the type tag in transmission. https://github.com/jsk-ros-pkg/jsk_model_tools/blob/master/collada_tools/src/collada_to_urdf.cpp#L497 It uses pr2_mechanism_model/SimpleTransmission whereas nowadays I find several tutorials using transmission_interface/SimpleTransmission instead of it. Doesn't it mean obsolete?

k-okada commented 5 years ago

It uses pr2_mechanism_model/SimpleTransmission whereas nowadays I find several tutorials using transmission_interface/SimpleTransmission instead of it.

that's correct. Please create PR if you need this.