jsk-ros-pkg / jsk_pr2eus

PR2 euslisp packages
https://github.com/jsk-ros-pkg/jsk_pr2eus
4 stars 41 forks source link

[WIP] [pr2eus_tutorials] Select grasp position via 2D image #437

Closed 708yamaguchi closed 4 years ago

708yamaguchi commented 4 years ago

Closes https://github.com/jsk-ros-pkg/jsk_pr2eus/issues/436

In this pull request, I did

[WIP] This pull request needs to be verified on real PR2 robot.

Here is sample implementation of this program: https://drive.google.com/file/d/1JbG7HTPiQ2x-l756z9GTLHitZslFYvxe/view?usp=sharing

knorth55 commented 4 years ago

first of all, have you tried current implementation of gazebo version?

708yamaguchi commented 4 years ago

Thank you for your advice.

I updated this pull request based on your advice (https://github.com/jsk-ros-pkg/jsk_pr2eus/issues/436 and https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/437 ).

Also, I confirmed that both of Rviz click demo and image_view2 click demo can be executed on gazebo simulation.

k-okada commented 4 years ago

great! can you update visualizatoin 1) when use click the image_view, add circle at that position (for a few seconds, if possible) 2) visualize ray line and target 3D point, ex) https://jsk-recognition.readthedocs.io/en/latest/jsk_pcl_ros/nodes/pointcloud_screenpoint.html

-- ◉ Kei Okada

2020年5月13日(水) 7:43 Naoya Yamaguchi notifications@github.com:

Thank you for your advice.

I updated this pull request based on your advice (#436 https://github.com/jsk-ros-pkg/jsk_pr2eus/issues/436 and #437 https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/437 ).

Also, I confirmed that both of Rviz click demo and image_view2 click demo can be executed on gazebo simulation.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/437#issuecomment-627638165, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADYNXHQZOAXX4CBTMPG5HDRRHGHDANCNFSM4M66I7KA .

708yamaguchi commented 4 years ago

1) when use click the image_view, add circle at that position (for a few seconds, if possible) 2) visualize ray line and target 3D point,

I pushed additional commits.

When we click image_view2 window,

For the second feature, I try to reuse https://github.com/jsk-ros-pkg/jsk_recognition/blob/master/jsk_pcl_ros/euslisp/pointcloud_screenpoint.l However, this script assumes the service version of PointcloudScreenpoint (I use the topic version in this pull request) Also, some functions are automatically executed when we load this script. Therefore, I gave up reusing this script and left a comment.

;; Mainly copied from https://github.com/jsk-ros-pkg/jsk_recognition/blob/master/jsk_pcl_ros/euslisp/pointcloud_screenpoint.l
(defun show-marker (frame p1)

Sample Screenshot 2020-05-13 22:10:30

k-okada commented 4 years ago

great work!