search

jsk-ros-pkg / jsk_robot

jsk-ros-pkg/jsk_robot
https://github.com/jsk-ros-pkg/jsk_robot
73 stars 97 forks source link

PR2 Noetic Branch #1774

Closed knorth55 closed 1 year ago

knorth55 commented 1 year ago

PR2 Noetic branch

Now PR1040 is using this branch.

knorth55 commented 1 year ago

/speech_to_text is published from /speech_to_text_mux. mux does not register publisher until the topic arrived.

https://github.com/ros/ros_comm/blob/842f0f026924323f605495da0b80493f15f0bdce/tools/topic_tools/src/mux.cpp#L154

tkmtnt7000 commented 1 year ago

Thank you. I understand.

https://github.com/jsk-ros-pkg/jsk_3rdparty/blob/d22e86c6ab79d8a36dbf9874518e383d306b0325/dialogflow_task_executive/launch/dialogflow_task_executive.launch#L18-L21

tkmtnt7000 commented 1 year ago

That's why we have to speak to PR2, "ねえねえ" twice when we are going to launch applications from dialogflow task executive.

knorth55 commented 1 year ago

yes. and the problem can be solved by this PR.

https://github.com/ros/ros_comm/pull/2305