search

jsk-ros-pkg / jsk_robot

jsk-ros-pkg/jsk_robot
https://github.com/jsk-ros-pkg/jsk_robot
73 stars 97 forks source link

[jsk_pr2_startup] Save face true in db_client.launch #1841

Closed tkmtnt7000 closed 1 year ago

tkmtnt7000 commented 1 year ago

I changed save_face arg into true to store face name to mongodb.

I would like to use face name to make pick-object demo richer.

sktometometo commented 1 year ago

I wonder who are in charge of develop/pr2-noetic branch and using it.

tkmtnt7000 commented 1 year ago

I think pr2-noetic branch change may have an influence especially on pr1040 users.

tkmtnt7000 commented 1 year ago

Sorry, I sent a additional fix commit but it doesn't seem that this PR contains it because of Github today's bug.

tkmtnt7000 commented 1 year ago

reviewしていただいた後にすみません．改めてpushし直したところ反映されたようです．

tkmtnt7000 commented 1 year ago

そうですね…… デフォルトがfalseだと思い込んでいました すみません