jsk-ros-pkg / jsk_robot

jsk-ros-pkg/jsk_robot
https://github.com/jsk-ros-pkg/jsk_robot
73 stars 97 forks source link

This PR added commits related to smach_to_mail.py that is in develop/fetch branch #1884

Closed k-okada closed 8 months ago

k-okada commented 8 months ago

@tkmtnt7000 Please check if this PR works and that it incldues all commits related to smach_to_mail.py that is in develop/fetch branch.

If you have tested a new feature or fix a serious bug on one robot and found it worth installing on othre robots, you may want to I suggest you create new PR against master branch and ask other robots to rebase origin/master

Related PRs

c.f. https://github.com/jsk-ros-pkg/jsk_robot/pull/1882

tkmtnt7000 commented 8 months ago

Sorry for late and thank you very much for your advice. (I don't know why I forgot making PR to master branch...)

@tkmtnt7000 Please check if this PR works and that it incldues all commits related to smach_to_mail.py that is in develop/fetch branch. If you have tested a new feature or fix a serious bug on one robot and found it worth installing on othre robots, you may want to I suggest you create new PR against master branch and ask other robots to rebase origin/master

I left a single comment, but I confirmed this PR woks at my local PC.

k-okada commented 8 months ago

@tkmtnt7000 please rebase origin/master at fetcha nd pr2 branch

tkmtnt7000 commented 8 months ago

Thank you. Now I am preparing to rebase origin/master branch. https://github.com/jsk-ros-pkg/jsk_robot/tree/develop/fetch-rebase-20231031 https://github.com/jsk-ros-pkg/jsk_robot/tree/develop/pr2-noetic-rebase-20231031