search

jsk-ros-pkg / jsk_roseus

ROS EusLisp Client
http://wiki.ros.org/roseus/Tutorials
17 stars 56 forks source link

Fix case function misuse in simple-action-server :set-preempted #673

Closed Affonso-Gui closed 1 year ago

Affonso-Gui commented 3 years ago

While working on https://github.com/jsk-ros-pkg/jsk_roseus/pull/672 I found out that when interrupted the euslisp server return the status 6 (preempting), while the same actionlib_tutorials node returns 2 (preempted).

This turned out to be happening from a misuse of the case function with multiple match cases in a single sentence, which are evaluated as quoted strings (symbols not values) and therefore are virtually unreachable. As a proof there was also a typo in the actionlib_msgs::GoalStatus::*preepmpting* variable.

Affonso-Gui commented 2 years ago

@k-okada Does the added tests serve you well?

k-okada commented 2 years ago

test is always welcome

Affonso-Gui commented 2 years ago

@k-okada Test was added here https://github.com/jsk-ros-pkg/jsk_roseus/pull/673/commits/ec7e18d61260736751eb35bb723d13f6c5c72e2d . Can we merge this?

Affonso-Gui commented 2 years ago

@k-okada Kindly ping.

Affonso-Gui commented 2 years ago

@k-okada I have added similar fixes and the tests are now passing after a few resets (pr2 tests timing out).