search

jsk-ros-pkg / jsk_roseus

ROS EusLisp Client
http://wiki.ros.org/roseus/Tutorials
17 stars 56 forks source link

add noetic test on travis #700

Closed k-okada closed 2 years ago

k-okada commented 2 years ago

to pass test on noetic, we need to fix test 1) roseus/test/test-param.l , from noetic, roslaunch set /roslaunch/uris/host_ params.

 (setq diff (remove-if #'(lambda (x) (substringp "/roslaunch/uris/host_" x)) diff)) ;; from noetic roslaunch set params https://github.com/ros/ros_comm/blob/07fb5469c71e10e4a05fa3a631897d9adece61c5/tools/roslaunch/src/roslaunch/launch.py#L448-L449

2) roseus/test/test-add-two-ints.l Call service call sometimes fails, it happens in melodic too, we recommend to use persistent service call for similar examples.

      (assert (= (+ (send req :a) (send req :b)) (send res :sum))
      ;; https://github.com/ros/ros_comm/issues/1976
      ;; service call sometimes fail
      (when (not (= (+ (send req :a) (send req :b)) (send res :sum)))
        (incf service-call-error)
        (warning-message 3 (format nil "[~A] integration failure (~A+~A)=~A(~A)/=~A(~A)~%"
                                   service-call-error
                                   a b (+ a b) (class (+ a b)) (send res :sum) (class (send res :sum)))))
      (assert (or (< service-call-error 3) (= (+ (send req :a) (send req :b)) (send res :sum)))