jsk-ros-pkg / jsk_roseus

ROS EusLisp Client
http://wiki.ros.org/roseus/Tutorials
16 stars 56 forks source link

euslisp dependency in roseus #743

Open v4hn opened 1 year ago

v4hn commented 1 year ago

I ran into this trying to get the jsk stacks to build in my ros-o buildfarm.

roseus find_packages euslisp, but the upstream euslisp package does not provide a cmake config upon installation, so building against debian's own euslisp-dev package fails for no real reason. Your eulisp-release package of course provides a package.xml and bloom will autogenerate a cmake config for it, which is why it works with the bloomed package in the ros ecosystem.

To follow ROS-best-practices, you should not rely on anything that is not available in upstream packages when using external packages packaged in ROS. The rest of the roseus CMakeLists.txt relies on multiple variables that are set through that cmake config, so I'm unsure how you can get rid of it. (I'm not using euslisp at all).

In Ubuntu 22.04 euslisp is at version 9.27 and you packaged 9.29 in noetic. Are there important differences for which you need the ros-packaged version?

@k-okada @knorth55