search

jsk-ros-pkg / jsk_travis

11 stars 23 forks source link

install protobuf 3.17.3 for python2 in dockerfiles #449

Open knorth55 opened 2 years ago

knorth55 commented 2 years ago

This PR fixes the build error in docker hub.

knorth55 commented 2 years ago

all test passed, but travis failed. I have no good idea to fix travis build error. It is caused by protobuf version, but travis install chainer and protobuf with rosdep, not pip.

mqcmd196 commented 2 years ago

@knorth55 BTW, the official says 3.17.3 is the last python2.x release https://github.com/protocolbuffers/protobuf/pull/8901 . Is it okay to install 3.18.0?

knorth55 commented 2 years ago

@mqcmd196 I didn't know the information! Thank you!