search

jsk-ros-pkg / jsk_visualization

jsk visualization ros packages
https://github.com/jsk-ros-pkg/jsk_visualization
324 stars 173 forks source link

use qt key namespace #870

Closed knorth55 closed 1 year ago

knorth55 commented 1 year ago

this is refactored version of #855

the magic number 16777248 comes from QT::Key_Shift.

In [1]: 0x01000020
Out[1]: 16777248

https://doc.qt.io/qt-5/qt.html

Qt::Key_Shift | 0x01000020
k-okada commented 1 year ago

you deleted }

 /github/home/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rviz_plugins/src/overlay_picker_tool.cpp: In member function ?virtual int jsk_rviz_plugins::OverlayPickerTool::processKeyEvent(QKeyEvent*, rviz::RenderPanel*)?:
  /github/home/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rviz_plugins/src/overlay_picker_tool.cpp:66:5: error: expected ?}? before ?else?
       else if (event->type() == QEvent::KeyRelease && event->key() == Qt::Key_Shift) {
       ^
  make[2]: *** [CMakeFiles/jsk_rviz_plugins.dir/src/overlay_picker_tool.cpp.o] Error 1
  make[2]: *** Waiting for unfinished jobs....
  /github/home/ros/ws_jsk_visualization/src/jsk_visualization/jsk_rviz_plugins/src/camera_info_display.cpp: In member function ?virtual void jsk_rviz_plugins::CameraInfoDisplay::drawImageTexture()?:
knorth55 commented 1 year ago

sorry it was my typo.