search

jsk-ros-pkg / jsk_visualization

jsk visualization ros packages
https://github.com/jsk-ros-pkg/jsk_visualization
324 stars 173 forks source link

use QFileDialog for file select #876

Closed knorth55 closed 1 year ago

knorth55 commented 1 year ago

SOMOSOMO, why do we put file path by string??????????????????? i feel like im in 1970s. (mouse is from 1983) https://en.wikipedia.org/wiki/Apple_Lisa

this PR change to use QFileDialog to open yaml file. I only tested on noetic

https://user-images.githubusercontent.com/9300063/234813532-4c18cc03-032a-4950-a449-6ca39016061e.mp4

k-okada commented 1 year ago

please test on melodic @knorth55

knorth55 commented 1 year ago

i dont have melodic computer, so i cannot check it quickly. i can do it on docker, but it is troublesome. i want a volunteer to check it on melodic.

tkmtnt7000 commented 1 year ago

I tested on melodic, but clicking and then calling dummy/button service seemed to fail. is it expected behavior?

https://user-images.githubusercontent.com/67531577/235175823-1f345e15-3b7b-4cc9-9c30-072f28b1ec1d.mp4

knorth55 commented 1 year ago

yes you need service server. you can launch the nodes in sample/sample_service_button.launch, but gui also launches, too. please ignore the gui or disable it, and run rqt_gui.

rqt_gui saves default config automatically, so please remove ~/.config/ros.org/rqt_gui.ini to refresh it.

tkmtnt7000 commented 1 year ago

Thank you. I have confirmed that this PR works on melodic, too.

https://user-images.githubusercontent.com/67531577/235291864-6aa248d5-2bf4-4153-bcb3-ff3f1121143e.mp4

knorth55 commented 1 year ago

@tkmtnt7000 Super! Thank you!

tokoro10g commented 1 year ago

This PR looks really nice! Would you mind merging this since there seem no issues?