search

jsk-ros-pkg / jsk_visualization

jsk visualization ros packages
https://github.com/jsk-ros-pkg/jsk_visualization
329 stars 173 forks source link

[jsk_rqt_plugins] Fix super function argument in tabbed_button_general #879

Closed Kanazawanaoaki closed 1 year ago

Kanazawanaoaki commented 1 year ago

The argument of the super function in tabbed_button_general.py has been modified so that it does not cause errors. 

roslaunch jsk_rqt_plugins sample_tabbed_buttons.launch

Before the modification, the following error occurred when executing the above sample, but after the modification, the inheritance of member variables required by https://github.com/jsk-ros-pkg/jsk_visualization/commit/4961b6987d3adda8eaf644c5e111cf9d225f7044 is successfully performed and the error does not occur. 

  File "/home/kanazawa/vive_ws/src/jsk-ros-pkg/jsk_visualization/jsk_rqt_plugins/src/jsk_rqt_plugins/tabbed_button_general.py", line 158, in __init__
    self._translator.tr("YAML files (*.yaml *.yml)"))
AttributeError: 'ServiceButtonGeneralWidget_in_tab' object has no attribute '_translator'

cc. @ojh6404

k-okada commented 1 year ago

@Kanazawanaoaki @ojh6404 thank you! , merged in #880 with tests