search

jskherman / imprecv

A no-frills curriculum vitae (CV) template using Typst and YAML to version control CV data.
Apache License 2.0
319 stars 38 forks source link

Feat/project tools #16

Closed Aparaxium closed 7 months ago

Aparaxium commented 7 months ago

Description

Allows the user to include tools used in projects.

The logic adds the tools under the affiliation. If the affiliation is none, it replaces the affiliation.

Relevant Pull Requests

This contains the pull requests:

Pull request 14 Pull request 15

jskherman commented 7 months ago

Thank you for your contribution, @Aparaxium. I have some thoughts on this PR. I think we could consider including the mention of tools in the bullet points, rather than having a separate line just for tools. This would help save valuable space.

Having a line for "Tools used" also seems specific for tech-oriented resumes (I try to make template as general as possible to apply to also other engineering fields). One can argue that for other engineering fields (or other non-STEM fields) that you could include tools like Aspen HYSYS, Figma, AutoCAD, IBM SPSS, etc. but it's not really the main point to highlight most of the time in a CV or résumé and can be relegated to the bottom section or briefly in the bullet points.

As of now, I don't see enough of a rationale to merge this but thank you for your PR.

Aparaxium commented 7 months ago

Hello,

I appreciate the feedback, after considering it, I believe you are correct in that the bullet points should explain the tools used.

I did try to make this as optional as possible. If the tools are omitted they will not be displayed, however, I understand if this pull request is not needed.

Aparaxium commented 7 months ago

Closing because I don't like this implementation and I will be making changes to it.