search

jskherman / imprecv

A no-frills curriculum vitae (CV) template using Typst and YAML to version control CV data.
Apache License 2.0
319 stars 38 forks source link

feat: allow multiple position in a workplace #18

Closed mangkoran closed 7 months ago

mangkoran commented 7 months ago

This PR adds support for multiple position/team in one workplace. Could you please recheck the updated JSON schema? I am afraid I missed one or two 😅

mangkoran commented 7 months ago

@jskherman I have updated the PR. Could you please check it again? Thank you.

Anyway, actually I'd like to reorder the section so Work -> Education instead of Education -> Work (which I felt a bit weird since we have the example.yml and Typst output arranged differently 😅). What's you preference: should I just add the commit in this PR or create a separate PR?

jskherman commented 7 months ago

@jskherman I have updated the PR. Could you please check it again? Thank you.

Anyway, actually I'd like to reorder the section so Work -> Education instead of Education -> Work (which I felt a bit weird since we have the example.yml and Typst output arranged differently 😅). What's you preference: should I just add the commit in this PR or create a separate PR?

It could really go either way for me, but Work => Education makes more sense. You can just add it as a commit here.

mangkoran commented 7 months ago

Updated with work and education switched.

mangkoran commented 7 months ago

I think that's all for now. Thank you for your help!