search

jskherman / imprecv

A no-frills curriculum vitae (CV) template using Typst and YAML to version control CV data.
Apache License 2.0
319 stars 38 forks source link

added credential id key for certificates #20

Closed 0x42697262 closed 2 months ago

0x42697262 commented 4 months ago

Allows the user to have an optional credential id right side of the certificate name.

I added this right after #cert.name

#h(1fr)ID: #cert.id

image

I would have used the word "Credential ID" but some ids are 40 characters long thus I used "ID" instead.

jskherman commented 4 months ago

Hi! Thank you for the pull request. Let me get back to you once I review it.

0x42697262 commented 4 months ago

Alright, I'll add it in a bit

0x42697262 commented 3 months ago

@jskherman ah, this should work now... i just noticed that the previous commits were wrong. This should work now?

It does work for this kind of input though:

certificates:
  - name: "Banana"
    date: 2022-07-01
    issuer: Another Issuer
    url: 
    id: ID-HERE-1412
  - name: "Microsoft maybe"
    date: 2021-04-11
    issuer: Github
    url: 
    id:
jskherman commented 2 months ago

Hi @0x42697262, sorry for only getting back to you at this time since I had a big exam to prepare for in the past few months. Yes, it works now. Thank you for your hard work. Then if this is final, I will merge this PR soon.

0x42697262 commented 2 months ago

Hi, it's understandable, don't worry much about it.

Unlike the previous commits, 8d3a28e fixed the issue where the "ID:" text is shown if you don't put a cert id. I have not tested it outside my use case but it does work properly now.