Closed 0x42697262 closed 2 months ago
Hi! Thank you for the pull request. Let me get back to you once I review it.
Alright, I'll add it in a bit
@jskherman ah, this should work now... i just noticed that the previous commits were wrong. This should work now?
It does work for this kind of input though:
certificates:
- name: "Banana"
date: 2022-07-01
issuer: Another Issuer
url:
id: ID-HERE-1412
- name: "Microsoft maybe"
date: 2021-04-11
issuer: Github
url:
id:
Hi @0x42697262, sorry for only getting back to you at this time since I had a big exam to prepare for in the past few months. Yes, it works now. Thank you for your hard work. Then if this is final, I will merge this PR soon.
Hi, it's understandable, don't worry much about it.
Unlike the previous commits, 8d3a28e fixed the issue where the "ID:" text is shown if you don't put a cert id. I have not tested it outside my use case but it does work properly now.
Allows the user to have an optional credential id right side of the certificate name.
I added this right after
#cert.name
I would have used the word "Credential ID" but some ids are 40 characters long thus I used "ID" instead.