Equals/hashcode method should use Arrays for array properties

jskov / openapi-jaxrs-client

An OpenAPI JAX-RS client code generator

Apache License 2.0

1 stars 4 forks source link

Equals/hashcode method should use Arrays for array properties #593

Closed jskov-jyskebank-dk closed 6 months ago

jskov-jyskebank-dk commented 6 months ago

From ns-meta, as it should look:

  private byte[] template = null;
...
  @Override
  public boolean equals(java.lang.Object o) {
   ...
    return ...
        Arrays.equals(this.template, xmlNs0TemplateDTO.template);

When using Objects.equals (current behavior) it is an array-reference comparison (which is the wrong sematics).

Same for hashCode

jskov-jyskebank-dk commented 6 months ago

Not even sure if this is a problem at present?! Just noticed it in an old DTO.

jskov-jyskebank-dk commented 6 months ago

yeah, old code