small fixes and additions

[ghost]

• Fixed archive backup method from backing up itself if archive was in specified backup folder
  • For example, attempting to backup "./BT_backup/" and storing the archive under "./BT_backup/archive.zip"
  • Caused recursive loop until space runs out
• Better string formatting for logging
  • Supplied message as parameter rather than doing string interpolation beforehand
  • https://stackoverflow.com/a/5082809/8612448
• strip() and lower() when checking input
• Use more f-strings

[jslay88]

18 closes this

[jslay88]

Sorry, waited forever for requested changes to be made and they weren’t. Was dealing with 7 issues at once. Will deal with it later.

On Thu, Feb 17, 2022 at 08:49 Peter Pagio @.***> wrote:

@.**** commented on this pull request.

In qbt_migrate/classes.py https://github.com/jslay88/qbt_migrate/pull/17#discussion_r809197114:

@@ -86,8 +90,9 @@ def discover_relevant_fast_resume(cls, bt_backup_path: str, existing_path: str, @classmethod def backup_folder(cls, folder_path: str, archive_path: str): cls.logger.info(f'Creating Archive {archive_path} ...')

• files_to_archive = os.listdir(folder_path)

This fix was not implemented in #18 https://github.com/jslay88/qbt_migrate/pull/18 merge. This stops the issue of archiving the archive file if the backup dir was set to the archive path.

— Reply to this email directly, view it on GitHub https://github.com/jslay88/qbt_migrate/pull/17#pullrequestreview-886169207, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABO7UUL4AUZMAYXWL5P3AJLU3UKHHANCNFSM5NQQU3ZQ . You are receiving this because you modified the open/close state.Message ID: @.***>

[ghost]

No problem! Thanks for your hard work.

On 2/17/2022 9:56 AM, jslay88 wrote:

Sorry, waited forever for requested changes to be made and they weren’t. Was dealing with 7 issues at once. Will deal with it later.

On Thu, Feb 17, 2022 at 08:49 Peter Pagio @.***> wrote:

@.**** commented on this pull request.

In qbt_migrate/classes.py https://github.com/jslay88/qbt_migrate/pull/17#discussion_r809197114:

@@ -86,8 +90,9 @@ def discover_relevant_fast_resume(cls, bt_backup_path: str, existing_path: str, @classmethod def backup_folder(cls, folder_path: str, archive_path: str): cls.logger.info(f'Creating Archive {archive_path} ...')

• files_to_archive = os.listdir(folder_path)

This fix was not implemented in #18 https://github.com/jslay88/qbt_migrate/pull/18 merge. This stops the issue of archiving the archive file if the backup dir was set to the archive path.

— Reply to this email directly, view it on GitHub

https://github.com/jslay88/qbt_migrate/pull/17#pullrequestreview-886169207, or unsubscribe

https://github.com/notifications/unsubscribe-auth/ABO7UUL4AUZMAYXWL5P3AJLU3UKHHANCNFSM5NQQU3ZQ . You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/jslay88/qbt_migrate/pull/17#issuecomment-1043112295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO3JPDRVSIUEIVSMWWN5RKLU3ULD3ANCNFSM5NQQU3ZQ. You are receiving this because you authored the thread.Message ID: @.***>

[jslay88]

21