Doesn't find all diffs in simple text

jsleroy / compare-plugin

Compare plugin for Notepad++

GNU General Public License v3.0

222 stars 52 forks source link

Open HeilandMicas opened 6 years ago

HeilandMicas commented 6 years ago

Hello,

I compared to txt-files with version 2.0.0 with following content:

File1: :103F9000010002000600FF00FF00FF0030003000BB

File2: :103F9000000002000600FF00FF00FF0030003000BC

Comparing leads to message "Files ... match". Thats really a big issue as I can't trust in any compare results any more.

I would be really happy, if you could fix this. Thank you.

Best regards

arjan64 commented 5 years ago

I have the same problem using Compare Plugin v2.0.0... This is a fatal problem!

xylographe commented 5 years ago

@pnedev

I can reproduce this (v2.0.0 32bit). Any idea what is going on here? And, more importantly, is this reproducible in ComparePlus?

pnedev commented 5 years ago

@xylographe ,

ComparePlus doesn't have that problem. It is an issue with original Compare plugin hashing.

xylographe commented 5 years ago

Thank you, Pavel.

I recently updated NPP from 7.5.9 to 7.7, hence I should now be able to update to ComparePlus as well.

pnedev commented 5 years ago

@xylographe ,

ComparePlus is not yet prepared for Notepad++ 7.7 API change. Please don't use it yet.

billybednar commented 4 years ago

It looks like the comparison is done only on a weak hash of each line, rather than the full text of the line.