jsliang / sublime-pelican

A Sublime Text plugin that makes writing Pelican articles easier and faster.
http://jsliang.com/sublime-pelican/
34 stars 9 forks source link

[Fix] #6 #30 #35

Closed Kristinita closed 7 years ago

Kristinita commented 7 years ago

1. Behavior before pull request

I create a new Markdown file → Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Insert Metadata → metadata insert:

Date Metadata

Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Update Article DateDate metadata variable update:

Update Date

2. Behavior after pull request

I add a new metadata variable Modified.

I create a new Markdown file → Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Insert Metadata → metadata with new Modified variable insert, Modified value = Date value:

Modified metadata

Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Update ModifiedModified variable update, Date variable stay constantly.

Update Modified

3. Argumentation

See @jachin arguments. Date variable — time, when we create article or page. Modified variable — last update time article or page. We must update Modified, not Date. See File Metadata section in official documentation.

4. Testing environment

Operating system and version: Windows 10 Enterprise LTSB 64-bit EN Sublime Text: Build 3126 Syntax: Markdown

5. Notes

  1. I'm sorry, I don't know reStructuredText — I don't know, how my changes will work in rst files.
  2. This pull request don't solve #30 issue. Modified variable doesn't update by save.

Thanks.

Kristinita commented 7 years ago

@jsliang , I fix #30 in new commit.

Thanks.

Kristinita commented 7 years ago

@jsliang , ping.

Thanks.

jsliang commented 7 years ago

Hi @Kristinita ,

Thank you for your PR and sorry for the late reply! Haven't been logged in to github for quite a while.

Jenny

Kristinita commented 9 months ago

Type: Update request 📈

@jsliang, what about merging st3 branch (with my pull request) to the master branch? Sublime Text 2 hasn’t been updated since 2013; in 2021, Sublime Text 4 appeared. I think it’s time to drop support for Sublime Text 2 or at least make the version for Sublime Text 3 as main branch.

Plugin version from st3 branch still works for me in Sublime Text 4 Build 4169.

Thanks.