search

jslicense / spdx-correct.js

correct invalid SPDX identifiers
Apache License 2.0
32 stars 22 forks source link

fix: identify GPL versions in last resort, and CDDL as CDDL-1.1 #20

Closed aviadatsnyk closed 7 years ago

kemitchell commented 7 years ago

First of all, @aviadatsnyk, thanks for the work on this! I know it's just a few lines, but I also know it takes time to figure out where to put those lines. Much appreciated.

As for the more general discussion, I think it's worth pointing out that this package has a fundamental problem:

  1. Its purpose isn't well specified.
  2. It achieves its vague purpose with a dirty, dirty hack of an approach.
  3. Despite all of that, a lot of people install and use it.

That opens up all kinds of room for well-meaning and well-thought-out confusion. Until somebody comes up with a cleaner definition of the goal, or a cleaner implementation, that sets out more robust guiding principles, every pull request will be muddled up by the inherent uncertainty.

If @aviadatsnyk is using the package, these changes make it behave more correctly in his use case, and they don't create bizarre or surprising behavior for anyone else, I'm inclined to take them.

aviadatsnyk commented 7 years ago

thanks @kemitchell

kemitchell commented 7 years ago

@aviadatsnyk, I will land this in 2.0.4 shortly. I will also invite you to the org.

The purpose of moving packages to the org was to make clear that while I'm not going anywhere, the community of both users and developers interested in these packages is far broader than just me, and the code "belongs" to whoever's willing to give their time and attention to improve this infrastructure for everyone. Run with it! Just make sure you create PRs for anything more than housekeeping, so all who care can weigh in.