search

jslirola / flarum-ext-login2seeplus

This extension hides code, links and images in a post for visitors.
https://discuss.flarum.org/d/24193-login-2-see-plus
MIT License
6 stars 14 forks source link

Sign-up link doesn't respect override from Flarum SSO plugin #25

Open sptcguy opened 6 months ago

sptcguy commented 6 months ago

In the Flarum SSO plugin, you can specify an override URL for the sign-up link/button to redirect users to a different site to sign up for an account.

The URL in the header changes successfully, however, this plugin does not respect the override. So the sign-up link presented by to the user in order to view a post triggers the default Flarum sign-up instead of redirecting them to our preferred location.

To reproduce:

  1. Install the Flarum SSO plugin.
  2. In the plugin settings, specify a new url for the sign-up link/button.
  3. Save
  4. Logout and navigate to a post.
  5. Click the sign-up button in the post area of the page.
jslirola commented 5 months ago

Hello, thanks for all the details to reproduce it.

I haven't had time to test it yet, but it makes sense that it doesn't work since the plugin requires some changes to make it compatible with the Flarum SSO plugin.

My availability is very limited, I'll let you know when I can take a look. In any case, collaborations are accepted and anyone can create a Pull Request to solve any issue.

sptcguy commented 3 months ago

A quick work-around I employed to hide the links is as follows:

  1. In admin area, go to "Appearance"
  2. Click "Edit custom CSS"
  3. And then put the following CSS override in:

.jslirolaLogin2seeplusRegister{ display: none;}